using msfs really helped me get atc comms down in the real world as well.
+1
While MSFS didn't teach me everything on how to listen and speak "pilot", it at least gave me a very good idea what to expect. I'd say it got me introduced to about 65% of what real world coms are like. My ear was already a little tuned by the time I started talking with ATC when I started flying IRL.
As far as preferences with MSFS - I'd recommend if you can run Flight Simulator X, do it.
However, Flight Simulator 2004 runs better with less hardware, as was previously mentioned. There's a ton of addons for it as well. But when it comes down to it, my advice is to try a little bit of everything and see what you like best.